*** menomc has joined #gnuenterprise
*** mnemoc has quit IRC
*** johannesV has joined #gnuenterprise
<johannesV> good morning
*** sjc has joined #gnuenterprise
*** kilo has joined #gnuenterprise
*** johannesV_ has joined #gnuenterprise
*** johannesV has quit IRC
*** sjc has quit IRC
*** dimas has joined #gnuenterprise
*** jamest has joined #gnuenterprise
<jamest> johannesV_: if reinhard isn't going to be back till friday I'll have to pick on you instead :)
<jamest> recordset.delete() changes a record status to either deleted or void
<jamest> however one of my users updated about 80 records then accidentaly hit the delete key on the next one
<jamest> in which case there is no way to unmark a record for delete
<jamest> at home i changed recordset.delete() to check do a if deleted|void set to modified
<jamest> but i'm not real keen on that as I can't get back the status prior to the delete action
<jamest> and I'm also not happy w/ using delete() as an implied undelete
<jamest> i was thinking about added a new functoin, undelete maybe as well as a self.__priorStatus
<jamest> then make forms check that records state when delete is pressed and if record is already deleted then reset to the pre-delete status via a call to undelete
<jamest> but with all the changes to datasources I didn't want to do anything without talking to the authors of GNUe DataSource 3.0+ Extreme Edition
*** kilo has quit IRC
<johannesV_> hmm
<johannesV_> jamest, after marking a record for delete (by deleting it) ... how could it be 'undeleted' then (since it isn't visible anymore, isn't it) ?
<jamest> in forms it's still visible
<jamest> the status display shows it as DEL
<johannesV_> i think going for a rollback isn't very usefull since all those 80 updates would be lost then, right ?
<jamest> that's what he had to do, a rollback
<jamest> when you press f5 in forms the recordset does a delete()
<johannesV_> ah, now i see .. the deleted record isn't removed
<jamest> which only tags the record to be deleted on the next post
<johannesV_> right
<jamest> i want a way to undo that action
<jamest> as in this case it cost him quite a bit of time
<johannesV_> ok
<jamest> because it was out item database and the delete would have blocked due to ref integ constraints
<jamest> s/out/our
<johannesV_> i think having an 'undo delete' would be a nice feature
<jamest> i think it's a simple feature
<johannesV_> which will be enabled on delete records only
<johannesV_> s/delete/deleted/
<jamest> as my delete() changes at home were 2 lines
<jamest> but didn't handle void/deleted records well - everything came back as modified
<johannesV_> void is the state after deleting a previously, but not commited insert ?
*** btami has joined #gnuenterprise
<jamest> right
<jamest> and so the modified state wouldn't do the right thing
<jamest> as the record never existed in the first place
<johannesV_> what's the state before deleting such a record
<jamest> empty or inserted
<jamest> look in Base/RecordSet.py
<johannesV_> ah, get reinhard on the phone ...
<jamest> search for void :)
<jamest> the first hit shows how the status change
<jamest> what I'm suggesting is we add a some type of predelete status var that the delete() function sets
<jamest> then an undelete function that resets the status to the stored predelete status
<jamest> (rather than make delete() toggle them back and forth)
*** kilo has joined #gnuenterprise
*** jcater has joined #gnuenterprise
<johannesV_> back
<johannesV_> hm, yeah, i think that's good idea, having something like "preDeleteState" or "cleanState"
<johannesV_> which well be moved into state on an undelete
<jamest> ok, i may add that today after I finish screwing up our main sales app
<johannesV_> great
*** dcmwai has joined #gnuenterprise
*** SachaS has joined #gnuenterprise
*** kilo has quit IRC
*** yure has joined #gnuenterprise
*** johannesV has joined #gnuenterprise
*** dimas has quit IRC
*** dimas has joined #gnuenterprise
*** johannesV_ has quit IRC
*** johannesV has quit IRC
*** sjc has joined #gnuenterprise
*** dcmwai has quit IRC
*** kilo has joined #gnuenterprise
*** btami has quit IRC
*** jamest has left #gnuenterprise
*** jcater has quit IRC
*** jamest has joined #gnuenterprise
*** jcater has joined #gnuenterprise
*** SachaS has quit IRC
*** kilo has quit IRC
*** yure has quit IRC
*** jamest has quit IRC
*** sjc has quit IRC
*** jcater has quit IRC
*** dcmwai has joined #gnuenterprise
*** mnemoc has quit IRC
*** Amorphous has quit IRC
*** mnemoc has joined #gnuenterprise
*** Amorphous has joined #gnuenterprise